fix serde not compiling for struct with lifetime #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ph0enixKM
requested changes
Nov 16, 2024
There was a problem hiding this comment.
Provided that the code variable contains a long script file (potentially 1 mln lines of code), this could lead to unnecessary value cloning. Of course, as of the alpha version, this won't be too much of an issue. Let's consider removing serde's serialise and deserialise for Reader as it's only used internally, and importing it publicly from the package should be considered a violation of encapsulation rules.
Ph0enixKM
requested changes
Nov 20, 2024
Co-authored-by: Phoenix Himself <[email protected]>
Ph0enixKM
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.