Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Allow unclosed region #56

Closed
KrosFire opened this issue Jul 24, 2024 · 2 comments · Fixed by #71
Closed

[FEATURE] Allow unclosed region #56

KrosFire opened this issue Jul 24, 2024 · 2 comments · Fixed by #71

Comments

@KrosFire
Copy link
Member

It would be very usefull for lexer to not throw an error when some defined region is left unclosed.

It's not always required in every lang to have every region closed and it would be usefull to handle it somewhat different
@Ph0enixKM
Copy link
Member

Ph0enixKM commented Jul 25, 2024 •
edited
Loading

Is allow_left_open enough? Perhaps it should be changed to allow_unclosed_region so that it makes more sense to developers?

@KrosFire
Copy link
Member Author

KrosFire commented Jul 25, 2024 •
edited
Loading

That's it. Maybe change the name, because at least to me it was not do obvious

@Ph0enixKM Ph0enixKM linked a pull request Nov 20, 2024 that will close this issue
[FEATURE] Allow unclosed region #56 #71
Merged
Ph0enixKM added a commit that referenced this issue Nov 22, 2024
@Ph0enixKM
[FEATURE] Allow unclosed region #56 (#71)
bd04ced 
* feat: rename allow_left_open to allow_unclosed_region

* feat: remove unused function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Allow unclosed region #56 amber-lang/heraclitus
2 participants
@Ph0enixKM @KrosFire