-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optional argument type matching #584
Conversation
maybe a test for this? Also I see that a lot of tests fails |
@Mte90 I'm still working on it. I'll convert to draft to avoid confusion |
Oops, totally a mistake of mine 😅 |
@mks-h no worries! It's a quick fix. I stumbled upon it when I was working on Amber's new marketing materials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets move the test for Generic "other" type into is_subset_of
as the first match arm, and leave is_allowed_in
intact. And +1 for validity tests on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions.
Currently declaring this function throws an error:
Even though this should work completely fine. The optional value is a subset of the argument type.