Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Git Bash on Windows #501

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

hdwalters
Copy link
Contributor

Implements #490.

@Mte90
Copy link
Member

Mte90 commented Oct 2, 2024

I don't use windows but looking at the code seems ok as it is just a more standard way to detect bash.

@Ph0enixKM Ph0enixKM linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good. Haven't tested it. Anyone can test it on a Windows machine? If not... then it's not a problem. We can merge and iterate on top of that.

@Mte90
Copy link
Member

Mte90 commented Oct 3, 2024

Let's merge and if we find issues we can deal later.

@Mte90 Mte90 merged commit 27569c4 into amber-lang:master Oct 3, 2024
1 check passed
@hdwalters hdwalters deleted the support-git-bash branch October 3, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Make Amber work in Git Bash on Windows
3 participants