Introduce Generic Arrays #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests pass for me locally, the CI seems to be broken |
Draft
|
Just re-run the action and fix it, until #383 get merged the CI sometimes doens't work. |
mks-h
force-pushed
the
generic-array
branch
from
13aefb9
to
f0f4dd7
Compare
|
Added an additional test. |
hdwalters
requested changes
Sep 10, 2024
mks-h
force-pushed
the
generic-array
branch
from
f0f4dd7
to
3c7031f
Compare
b1ek
reviewed
Sep 11, 2024
b1ek
reviewed
Sep 11, 2024
mks-h
force-pushed
the
generic-array
branch
from
3c7031f
to
6fcebe8
Compare
hdwalters
approved these changes
Sep 11, 2024
Ph0enixKM
reviewed
Sep 12, 2024
mks-h
force-pushed
the
generic-array
branch
from
6fcebe8
to
ef45d69
Compare
KrosFire
reviewed
Sep 13, 2024
mks-h
force-pushed
the
generic-array
branch
from
ef45d69
to
05de6da
Compare
KrosFire
requested changes
Sep 14, 2024
b1ek
reviewed
Sep 15, 2024
b1ek
reviewed
Sep 15, 2024
Ph0enixKM
requested changes
Sep 15, 2024
mks-h
force-pushed
the
generic-array
branch
from
67900e5
to
0ed18e2
Compare
KrosFire
reviewed
Sep 15, 2024
KrosFire
previously requested changes
Sep 15, 2024
mks-h
force-pushed
the
generic-array
branch
from
0ed18e2
to
37ce904
Compare
Ph0enixKM
requested changes
Sep 20, 2024
mks-h
force-pushed
the
generic-array
branch
from
37ce904
to
be2a0b7
Compare
Ph0enixKM
requested changes
Sep 27, 2024
mks-h
force-pushed
the
generic-array
branch
from
be2a0b7
to
40318a5
Compare
b1ek
reviewed
Sep 30, 2024
mks-h
force-pushed
the
generic-array
branch
from
40318a5
to
c41ca60
Compare
b1ek
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the simple generic array type from #391. Regular generics are out of scope.
Handling logic is combined with the
Failabletype, centralized, and generalized into the idea of "subset" types. Subset types (purely internal term) are those that are contained within another type, e.g.Textis a subset ofText?, and[Num]is a subset of generic[]. This system should also help implement union types.