Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests not being rerun #467

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Conversation

b1ek
Copy link
Member

@b1ek b1ek commented Sep 7, 2024

i've got a feeling that most of you guys have faced this each time you add a new test.

turns out it has been already known, and the fix is pretty simple

@b1ek
Copy link
Member Author

b1ek commented Sep 7, 2024

the build-helper crate exists only at the build time and does not affect production/debug/any other build

Copy link
Member

@KrosFire KrosFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mks-h
Copy link
Member

mks-h commented Sep 8, 2024

For me this change recompiles the whole test suite each time I run cargo test, which takes up no more than 5 seconds in debug mode. And in release mode it takes up almost a whole minute, but it seems there's no need to run tests in release mode.

Honestly, I'm fine with this, so LGTM.

Copy link
Contributor

@hdwalters hdwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@b1ek b1ek merged commit 72ed1e8 into amber-lang:master Sep 8, 2024
1 check passed
@b1ek b1ek deleted the fix-tests-not-being-rerun branch September 8, 2024 23:06
Mte90 pushed a commit to Mte90/Amber that referenced this pull request Sep 19, 2024
* fix: tests not being rerun after new test has been added

* fix: add newline at end of build.rs

* fix: add build-helper to deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants