Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): adding documentation for the exit builtin function #54

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

MuhamedMagdi
Copy link
Contributor

@MuhamedMagdi MuhamedMagdi commented Oct 6, 2024

Adding the documentation for the new exit builtin function

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amber-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 11:44am

Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mte90
Copy link
Member

Mte90 commented Oct 7, 2024

I think that it is the case to merge when the new amber version is released officially.

Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! 👏

@Ph0enixKM
Copy link
Member

Oh hang on. I thought we already support exit, but we're still waiting for amber-lang/amber#566 to get merged. Merge is coming pretty soon

@Ph0enixKM
Copy link
Member

@Mte90 merging this one before my big change will be easier to resolve (I only moved the files in my change so git knows that it needs to update them in the other directory). I advise to merge them both at the same time - this one first.

@Mte90
Copy link
Member

Mte90 commented Nov 14, 2024

ready for you

@Ph0enixKM Ph0enixKM merged commit efe2497 into amber-lang:master Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants