Change default branch behavior to remove defaulting to 'master' branch. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
Prior to this PR ion-test-driver would default to using
masteras the branch for cloned repositories. We have a mix now where some of our repositories have not migrated to usingmainover master, which has led to a few test failures when pullingion-tests(example).This PR changes ion-test-driver so that if a revision is not provided, rather than assuming the name of the active branch, ion-test-driver will leave the cloned version of the repo alone, defaulting to the repository's configured active branch.
The code already supported having a missing revision, so this PR ultimately just removes the defaulting to
master, and removes the declared default revisions in the implementation list so that they do not have to stay in sync with the repositories.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.