[serde] Implement serde Serializer/Deserializer::is_human_readable #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will return true for text encodings, false for binary. is_human_readable is used to determine whether Serialize implementations should serialize in human-readable form. Some types have a human-readable form that may be somewhat expensive to construct, as well as a binary form that is compact and efficient. Fixes amazon-ion#790
|
As per offline discussion, this PR requires changes on serialization side to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will return true for text encodings, false for binary. is_human_readable is used to determine whether Serialize implementations should serialize in human-readable form.
Some types have a human-readable form that may be somewhat expensive to construct, as well as a binary form that is compact and efficient.
Fixes issue 790
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.