Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional tooling access methods, trait impls, and a bug fix #780

Merged
merged 3 commits into from
May 31, 2024
Merged

Additional tooling access methods, trait impls, and a bug fix #780

merged 3 commits into from
May 31, 2024

Commits on May 31, 2024

  1. Additional tooling access methods, trait impls, and a bug fix 

    * Renames the `RawReaderType` enum to `IonEncoding` because it is
  generally useful in other contexts too.
* Adds the ability for system and raw readers using `AnyEncoding`
  to report the encoding they're currently using.
* Adds `value_span` and `annotations_span` methods to `LazyValue`
  in addition to `span`, which includes both the annotations and
  the value.
* The binary 1.0 and 1.1 writers will now write `f64`s as `f32`s
  to save space when it can be done losslessly.
* Adds `WriteAsIon` implementations for `LazyList`, `LazySExp`,
  and `LazyStruct`.
* Adds `IntoIterator` impls for `LazyList`, `LazySExp` and
  `LazyStruct`. Previously, they only existed for borrowed (`&`)
  references to those types.
* Fixes a bug in the `StreamingRawReader` that could cause
  a value's annotations span to be overwritten if reading that
  value consumed all of the data remaining in the buffer.
* Renames the feature-gated `LazyValue::lower` method (which
  returns a `LazyExpandedValue`) to `LazyValue::expanded()`
  so I could add a `raw()` method alongside it that returns
  the underlying `LazyRawValue` when applicable.
    @zslayton
    zslayton committed May 31, 2024
    Configuration menu
    Copy the full SHA
    450a2a0 View commit details
    Browse the repository at this point in the history

  2. Adds SmallestFloatRepr trait for f64, f32

    @zslayton
    zslayton committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7d0128d View commit details
    Browse the repository at this point in the history

  3. unsafe explanations

    @zslayton
    zslayton committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a63a5d0 View commit details
    Browse the repository at this point in the history