Removes Coefficient and Sign from the root #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage ? 82.39%
=======================================
Files ? 111
Lines ? 19552
Branches ? 19552
=======================================
Hits ? 16110
Misses ? 1899
Partials ? 1543
☔ View full report in Codecov by Sentry. |
popematt
approved these changes
Jul 12, 2023
Comment on lines
-16
to
+21
| /// Serializes a single [`Element`] at the current depth of the writer. | ||
| fn write_element(&mut self, element: &Element) -> IonResult<()>; | ||
|
|
||
| /// Serializes a single [`Value`] at the current depth of the writer. | ||
| // TODO: consider extracting this to a ValueWriter trait. | ||
| fn write_value(&mut self, value: &Value) -> IonResult<()>; | ||
|
|
||
| /// Serializes a single [`Element`] at the current depth of the writer. | ||
| fn write_element(&mut self, element: &Element) -> IonResult<()>; | ||
|
|
There was a problem hiding this comment.
Is this change intentionally part of this PR?
There was a problem hiding this comment.
Oops! The change was intentional, but not meant for this PR. Good eye.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the re-export of
SignandCoefficientfrom the crate root. They can still be accessed at:ion_rs::decimal::coefficient::{Coefficient, Sign}.Fixes #586.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.