Added new routing option: SingleNodeRoutingInfo::RandomPrimary
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eran Ifrah <[email protected]>
Signed-off-by: Eran Ifrah <[email protected]>
ikolomi
reviewed
Oct 7, 2024
| @@ -730,6 +727,9 @@ where | |||
| SingleNodeRoutingInfo::SpecificNode(route) => { | |||
| self.get_connection(&mut connections, route)? | |||
| } | |||
| SingleNodeRoutingInfo::RandomPrimary => { | |||
There was a problem hiding this comment.
Why is there no distinction at line 462 between RandomPrimary and Random, but here they are processed differently? Is there a bug at line 462?
There was a problem hiding this comment.
- The code for
RandomPrimaryis correct - The
RoutingInfo::SingleNode(SingleNodeRoutingInfo::Random)was not changed (replaced the old code with a call toRoute::new_random_primary()
Having said that, there is no bug on that line, however there can be an optimization: for example we could add a check to see whether the cmd is readonly, and in case it does, we could allow "read-from-replica" instead of "SlotAddr::Master`.
If you think that this is correct, we could open a new bug and fix it in a different PR (I prefer not to mix changes in a single PR)
Signed-off-by: Eran Ifrah <[email protected]>
ikolomi
reviewed
Oct 7, 2024
redis/src/cluster_routing.rs
Outdated
|
|
||
| /// Choose a random slot from `0..SLOT_SIZE` (excluding) | ||
| fn random_slot() -> u16 { | ||
| use rand::Rng; |
There was a problem hiding this comment.
please put "use" alongside all the others at the top
Signed-off-by: Eran Ifrah <[email protected]>
ikolomi
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RandomPrimary.Route::new_random_primary()EVAL,EVALSHAandFCALLwhen no arguments are providedThis commit is (part of) the fix for this issue: valkey-io/valkey-glide#1569
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.