Test against Valkey in CI. #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the CI pipeline to not use a cartesian product of Rust & DB version, and instead of test all Rust versions against a single DB version, and all DB versions against stable Rust, since the two are orthogonal. This allows us to add more DB types and versions and only add 1 CI action per version.
nihohit
force-pushed
the
smaller-ci-upstream
branch
from
ecfec21
to
c655f8c
Compare
|
@barshaul rebased over the lint fix. |
barshaul
reviewed
Sep 12, 2024
.github/workflows/rust.yml
Outdated
Comment on lines
44
to
60
| { | ||
| rust: beta, | ||
| db-org: redis, | ||
| db-name: redis, | ||
| db-version: 7.2.4 | ||
| }, | ||
| { | ||
| rust: nightly, | ||
| db-org: redis, | ||
| db-name: redis, | ||
| db-version: 7.2.4 | ||
| }, | ||
| { | ||
| rust: 1.65.0, | ||
| db-org: redis, | ||
| db-name: redis, | ||
| db-version: 7.2.4 |
There was a problem hiding this comment.
Thanks again!
Can you change the default engine to valkey 7.2.4?
There was a problem hiding this comment.
tests failed because there's no valkey 7.2.4 in that path. returned to 7.2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the CI pipeline to not use a cartesian product of Rust & DB version, and instead of test all Rust versions against a single DB version, and all DB versions against stable Rust, since the two are orthogonal.
This allows us to add more DB types and versions and only add 1 CI action per version.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.