Fix X-Ray metadata unmarshaling #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-mateen
reviewed
Jun 21, 2023
jefchien
commented
Jun 21, 2023
adam-mateen
previously approved these changes
Jun 21, 2023
Add back to default metadata if unable to unmarshal.
adam-mateen
approved these changes
Jun 21, 2023
adam-mateen
previously approved these changes
Jun 21, 2023
adam-mateen
approved these changes
Jun 21, 2023
sky333999
approved these changes
Jun 21, 2023
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The X-Ray receiver marshals the metadata from the X-Ray SDK, but the exporter doesn't unmarshal the metadata, which results in squashed and incorrectly nested metadata. See issue for examples.
Link to tracking Issue: open-telemetry#23610
Testing: Added unit tests.