Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] Make detect no-op for non-EKS environments #230

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jefchien
Copy link

@jefchien jefchien commented Sep 3, 2024

Description: Instead of erroring out in the constructor, log the error as a debug log and make the Detect function a no-op. Similar to ecs detector

// don't attempt to fetch metadata if there's no provider (incompatible env)
if d.provider == nil {
return pcommon.NewResource(), "", nil
}

Link to tracking Issue: N/A

Testing: Updated unit tests.

@jefchien jefchien merged commit 5944792 into aws-cwa-dev Sep 3, 2024
146 checks passed
@jefchien jefchien deleted the fix-resource-detection branch September 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants