Filter out Prometheus scrape_ metrics if EnhancedContainer Insights is enabled #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadpatel
reviewed
Oct 10, 2023
sky333999
reviewed
Oct 10, 2023
chadpatel
previously approved these changes
Oct 11, 2023
sky333999
reviewed
Oct 11, 2023
chadpatel
approved these changes
Oct 11, 2023
sky333999
approved these changes
Oct 11, 2023
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Filter out scrape_ metric namely - "up", "scrape_duration_seconds", "scrape_samples_post_metric_relabeling", "scrape_samples_scraped", "scrape_series_added" taken from https://prometheus.io/docs/concepts/jobs_instances when enhancedContainerInsights is enabled in the EMF exporter
Testing:
