Support db_datareader/db_datawriter #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rishabhtanwar29
approved these changes
Oct 22, 2024
shalinilohia50
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 23, 2024
### Description Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 ### Issues Resolved Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 31, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
tanscorpio7
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 5, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 15, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
thephantomthief
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 20, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
thephantomthief
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 20, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 5, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
shardgupta
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
Implement database roles `db_datareader` and `db_datawriter` * Members of the db_datareader fixed database role can read all data from all user tables and views. User objects can exist in any schema except sys and INFORMATION_SCHEMA. * Members of the db_datawriter fixed database role can add, delete, or change data in all user tables. In most use cases, this role is combined with db_datareader membership to allow reading the data that is to be modified. Engine PR: amazon-aurora/postgresql_modified_for_babelfish#98 Task: [BABEL-3883](https://jira.rds.a2z.com/browse/BABEL-3883) Signed-off-by: Shalini Lohia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to skip dumping these fixed roles db_datareader/db_datawriter for inbuilt databases like master, tempdb, msdb.
Extension PR: amazon-aurora/babelfish_extensions#68
Issues Resolved
Task: BABEL-3883
Signed-off-by: Shalini Lohia [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.