Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fixed database role db_accessadmin #66

Merged
merged 47 commits into from
Oct 18, 2024
Merged

Support fixed database role db_accessadmin #66

merged 47 commits into from
Oct 18, 2024

Conversation

tanscorpio7
Copy link

@tanscorpio7 tanscorpio7 commented Oct 16, 2024 •
edited
Loading

Description

For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

  1. CREATE SCHEMA
  2. CREATE/DROP USER
  3. ALTER USER
  4. They always have connect permission

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447

Extension PR: #66

Issues Resolved

[BABEL-5136]

Test Scenarios Covered

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

tanscorpio7 and others added 30 commits September 25, 2024 09:13
@tanscorpio7
support db_accessadmin
1c2e0d9 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
empty commit to rerun actions
9366d6f 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
Merge branch 'server-database-roles-4-x' into BABEL-5136
60eb635
@tanscorpio7
add basic tests
1d235d6 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix get_authid_user_ext_physical_name
6778242 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
refactor
aa8c3a5 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
refactor is_role() & is_user() to one function
04161b7 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
address comments
c26714a 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
2f141fa 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
ef05577 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
Merge remote-tracking branch 'upstream/BABEL_4_X_DEV' into BABEL-5136
fd28fd0
@tanscorpio7
empty commit to rerun actions
f8263ad 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
5ccc553 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
2c6071d 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
8e236af 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
add test to upgrade
262ab3b 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
add test to upgrade
3377700 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
Merge remote-tracking branch 'origin/BABEL_4_X_DEV' into BABEL-5136
fc5a463
@tanscorpio7
Merge remote-tracking branch 'origin/BABEL_4_X_DEV' into BABEL-5136
5ddd9c0
@tanscorpio7
fix tests
7b373b1 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
2e2e2f2 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
502e58f 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
fdb5831 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
4ef8ff2 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
5361565 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix
e7e32fd 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
empty
ff34749 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
see dump restore actions logs
6473217 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
ssh into github actions host
c3949e0 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
remove temp changes and reset password for login in verify file
55a8d90 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7 tanscorpio7 mentioned this pull request Oct 16, 2024
Closed
1 task
@coveralls
Copy link

coveralls commented Oct 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11400355167

Details

  • 195 of 268 (72.76%) changed or added relevant lines in 9 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 74.551%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contrib/babelfishpg_tsql/src/catalog.c 43 46 93.48%
contrib/babelfishpg_tsql/src/pl_handler.c 63 66 95.45%
contrib/babelfishpg_tsql/src/multidb.c 23 27 85.19%
contrib/babelfishpg_tsql/src/dbcmds.c 30 93 32.26%
Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tsql/src/catalog.c 1 85.45%
contrib/babelfishpg_tsql/src/rolecmds.c 1 86.24%
contrib/babelfishpg_tds/src/backend/tds/tdsutils.c 2 73.61%
Totals Coverage Status
Change from base Build 11383054325: -0.04%
Covered Lines: 45378
Relevant Lines: 60868
💛 - Coveralls

@tanscorpio7
refactor name for upgrade function
b640fea 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
use IS_BBF_BUILT_IN_DB macro in some more places
e77a11f 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
empty
a7c8e74 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7
fix upgrade file
0c92528 
Signed-off-by: Tanzeel Khan <[email protected]>
HarshLunagariya
HarshLunagariya approved these changes Oct 18, 2024
View reviewed changes
contrib/babelfishpg_tsql/src/session.c Outdated
* Callers should NOT pfree the return value
*/
const char *
get_cuurent_pltsql_db_name(void)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: *current

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@tanscorpio7
fix typo
83e9771 
Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7 tanscorpio7 merged commit 82d5e32 into amazon-aurora:server-database-roles-4-x Oct 18, 2024
46 checks passed
tanscorpio7 added a commit that referenced this pull request Oct 21, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
4cc60db 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
tanscorpio7 added a commit that referenced this pull request Oct 31, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
e3ae97c 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
tanscorpio7 added a commit that referenced this pull request Nov 5, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
8210e0d 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
anju15bharti pushed a commit that referenced this pull request Nov 15, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
64693f4 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
thephantomthief pushed a commit that referenced this pull request Nov 20, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
d287163 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
thephantomthief pushed a commit that referenced this pull request Nov 20, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
598c96e 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
anju15bharti pushed a commit that referenced this pull request Dec 5, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
47c6b90 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
anju15bharti pushed a commit that referenced this pull request Dec 12, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
3d38190 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
anju15bharti pushed a commit that referenced this pull request Dec 12, 2024
@tanscorpio7
Support fixed database role db_accessadmin (#66)
13d0506 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
chxwang pushed a commit that referenced this pull request Dec 12, 2024
@tanscorpio7 @shardgupta
Support fixed database role db_accessadmin (#66)
5afdeb2 
Description
For review comments see babelfish-for-postgresql#2970

Support fixed database role db_accessadmin in babelfish.
Member of db_accessadmin can do the following

CREATE SCHEMA
CREATE/DROP USER
ALTER USER
They always have connect permission
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#447
Extension PR: #66
Issues Resolved
[BABEL-5136]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalinilohia50 shalinilohia50 shalinilohia50 left review comments

@HarshLunagariya HarshLunagariya HarshLunagariya approved these changes

@rishabhtanwar29 rishabhtanwar29 Awaiting requested review from rishabhtanwar29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanscorpio7 @coveralls @HarshLunagariya @shalinilohia50