This repository has been archived by the owner on May 16, 2020. It is now read-only.
Solution Helper still had references to old bucket name #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y bucket. As a result the stack would fail to deploy as it presummed the bucket was named '-region'
|
Hello, Thanks for raising the issue. We apologize for the confusion. We will update the readme with correct instructions, with the next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
build-s3-dist.sh had an expectation of 3 parameters, of which only 2 were referenced in the README. The 3rd parameter appears to be an old variable as it is used by the SolutionHelper to load the helper.zip code which would refer to the TEMPLATE_BUCKET_NAME.
Removed all references to DIST_BUCKET_NAME as it caused the cloudformation deploy to fail.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.