Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-optimization to AmazingPrint::ActiveRecord#cast #117

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Micro-optimization to AmazingPrint::ActiveRecord#cast #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99234f6
Micro-optimization to AmazingPrint::ActiveRecord#cast
jdelStrother Aug 23, 2024
af5bc05
Merge branch 'master' into ancestors-optimization
HarlemSquirrel Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/amazing_print/ext/active_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ def cast_with_active_record(object, type)
cast = :active_record_instance
elsif object.is_a?(::ActiveModel::Errors)
cast = :active_model_error
elsif object.is_a?(Class) && object.ancestors.include?(::ActiveRecord::Base)
elsif object.is_a?(Class) && object <= ::ActiveRecord::Base
cast = :active_record_class
elsif type == :activerecord_relation || object.class.ancestors.include?(::ActiveRecord::Relation)
elsif type == :activerecord_relation || object.is_a?(::ActiveRecord::Relation)
cast = :array
end
cast
Expand Down
Loading