Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve user color defaults #114

Merged

Conversation

joast
Copy link
Contributor

@joast joast commented Jun 20, 2024

User set default colors are lost after the first call to anything
that colorizes data. For example, without this change:
AmazingPrint.defaults = { color: { integer: :blueish } }
ap 123 # output with bluish color
ap 123 # output with blue color (the builtin default)

joast and others added 2 commits June 20, 2024 13:35
   User set default colors are lost after the first call to anything
   that colorizes data. For example, without this change:
     AmazingPrint.defaults = { color: { integer: :blueish } }
     ap 123 # output with bluish color
     ap 123 # output with blue color (the builtin default)
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you!

@HarlemSquirrel HarlemSquirrel added this pull request to the merge queue Dec 19, 2024
Merged via the queue into amazing-print:master with commit 9dcae94 Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants