-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support semantic-release higher than version 19 #235
base: main
Are you sure you want to change the base?
feat: support semantic-release higher than version 19 #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't removing the reload going to mean we are using the same semantic-release/npm each time?
@jackmoxley, That depends on how |
@g-ongenae Unfortunately @amanda-mitchell do you have any plans to make this work with ECMAScript modules? I've tried a solution with Worker threads (because each thread gets its own module cache), but that doesn't work because of function arguments that can't be cloned (probably The safest solution I can think of is to actually copy the whole |
I’ve been reading up on the internals of how node handles es modules, and I think that the cache can be deliberately suppressed by including a unique query string on each import. I’ll try to find some time to play around with this soon. |
Oh wow, that is clever. I think that's going to work for a single ES module. The problem is that you can only add a query string to your import, but not the following internal imports. A possible solution could be to bundle the whole package in a single file upon install. |
Alternatively we could ask the maintainers of semantic-release to remove the state on module level (or send a PR). It's probably also more testable this way. |
True! I have not yet looked into where the module level state is stored in the latest version of the module: this will only work if it’s at the top.
That’s certainly the most attractive option! …although I also wouldn’t hold my breath for it, given the “you shouldn’t do that” response to the issue you opened. |
Update: I took a quick peek through semantic-release/npm this morning, and in the current code, it looks like the only module-level state is the name of a temp file that is created in the root module. Knowing this, it should be able to orchestrate something that works for the current version. |
Fix #176.
Tested on @algoan/pubsub for publishing v6: