Use -q by default for operations that might show progress bars

Progress bars are very slow to draw in comint
amake · Aug 14, 2024 · 594b0dc · 594b0dc
1 parent dc1bc52
commit 594b0dc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/macports-installed.el b/macports-installed.el
@@ -284,19 +284,19 @@ Acts within the region when active, otherwise on entire buffer."
         (when (macports-installed--prompt-transaction-p uninstall deactivate activate requested unrequested)
           (let ((uninstall-cmd (when uninstall
                                  (macports-core--privileged-command
-                                  `("-N" "uninstall" ,@(macports-installed--list-to-args uninstall)))))
+                                  `("-q" "uninstall" ,@(macports-installed--list-to-args uninstall)))))
                 (deactivate-cmd (when deactivate
                                   (macports-core--privileged-command
-                                   `("-N" "deactivate" ,@(macports-installed--list-to-args deactivate)))))
+                                   `("-q" "deactivate" ,@(macports-installed--list-to-args deactivate)))))
                 (activate-cmd (when activate
                                 (macports-core--privileged-command
-                                 `("-N" "activate" ,@(macports-installed--list-to-args activate)))))
+                                 `("-q" "activate" ,@(macports-installed--list-to-args activate)))))
                 (requested-cmd (when requested
                                  (macports-core--privileged-command
-                                  `("-N" "setrequested" ,@(macports-installed--list-to-args requested)))))
+                                  `("-q" "setrequested" ,@(macports-installed--list-to-args requested)))))
                 (unrequested-cmd (when unrequested
                                    (macports-core--privileged-command
-                                    `("-N" "unsetrequested" ,@(macports-installed--list-to-args unrequested))))))
+                                    `("-q" "unsetrequested" ,@(macports-installed--list-to-args unrequested))))))
             (macports-core--exec
              (string-join
               (remq nil (list uninstall-cmd deactivate-cmd activate-cmd requested-cmd unrequested-cmd))

diff --git a/test/macports-installed-tests.el b/test/macports-installed-tests.el
@@ -171,11 +171,11 @@
                t))
             ((symbol-function #'macports-core--exec)
              (lambda (cmd &rest _)
-               (should (equal (concat "sudo port -N uninstall piyo @2.0.1 && "
-                                      "sudo port -N deactivate foobar @1.0_0 && "
-                                      "sudo port -N activate hogefuga @123_4 && "
-                                      "sudo port -N setrequested bizzbazz @0.1_0 && "
-                                      "sudo port -N unsetrequested bazinga @20220426+blah")
+               (should (equal (concat "sudo port -q uninstall piyo @2.0.1 && "
+                                      "sudo port -q deactivate foobar @1.0_0 && "
+                                      "sudo port -q activate hogefuga @123_4 && "
+                                      "sudo port -q setrequested bizzbazz @0.1_0 && "
+                                      "sudo port -q unsetrequested bazinga @20220426+blah")
                               cmd)))))
     (macports-installed)
     (macports-installed-mark-toggle-requested)