added kustomize support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logdnalf
suggested changes
Apr 8, 2020
| - ClusterRole.yaml | ||
| - ClusterRoleBinding.yaml | ||
| - ServiceAccount.yaml | ||
| - ZZ_Deployment.yaml |
There was a problem hiding this comment.
I believe you need to add a newline at the end of line 8.
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| resources: | ||
| - crds/k8s_v1alpha1_redis_crd.yaml |
There was a problem hiding this comment.
I've seen with other Operator implementations two behaviors different to the one used by this Operator:
- The Operator does inject the CRDs itself at start up
- The Operator does not inject the CRDs itself at start up, but you have to do manually. But you can only apply the CRD YAML once the Operator has started up and declared that it supports this CRD.
Are you sure that applying the CRD before having the Operator running will work?
There was a problem hiding this comment.
Shouldn't be a problem. I've created helm chart for this operator, which installs CRDs before applying any other resources, works like a charm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add this file to support kustomize
This will allow people who use kustomize to deploy this operator with a single http url in their kustomise resources