Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in getExistingHelpers for ConvexMonotone interpolation #196

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Fix bug in getExistingHelpers for ConvexMonotone interpolation #196

merged 1 commit into from
Jun 11, 2018

Conversation

igitur
Copy link
Collaborator

@igitur igitur commented Jan 30, 2018

No description provided.

amaggiulli
amaggiulli reviewed Feb 1, 2018
View reviewed changes
Copy link
Owner

@amaggiulli amaggiulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a bug ?
Here we want to remove the last point in interpolation , not the last item on retArray .

@igitur igitur force-pushed the fix-sessionhelpers-for-convextmonotone branch from 7ebd482 to 11d5cc5 Compare February 5, 2018 16:43
@igitur
Copy link
Collaborator Author

igitur commented Feb 5, 2018

@amaggiulli This change is to fix the bug that makes @tournierjc 's ITrait refactoring unit tests fail. The bug is that xBegin_ contains the full list x values instead of only the 3 values which are applicable for the section of the convex monotone curve. As it is currently retArray.Remove(xBegin_.Last()); doesn't make any change to retArray because retArray.Keys doesn't contain xBegin_.Last().

@igitur
Copy link
Collaborator Author

igitur commented Jun 11, 2018

@amaggiulli Anything more to be done on this PR?

@amaggiulli amaggiulli merged commit 781a2aa into amaggiulli:develop Jun 11, 2018
@igitur igitur mentioned this pull request Jun 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaggiulli amaggiulli amaggiulli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igitur @amaggiulli