Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOP_CreateFormOfPayment allow sequence number 0 #162

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

therealartz
Copy link
Collaborator

Fop sequence number check must be changed, because empty() method returns false, when $sequenceNr = 0.
It breaks the struct when trying to add a form of payment (FP) element including both old and new forms of payment where old must have 0 sequence number
(First example on FOP_CreateFormOfPayment examples page at extranet)

<fopSequenceNumber>
    <sequenceDetails>
        <number>0</number>
    </sequenceDetails>
</fopSequenceNumber>

@coveralls
Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage remained the same at 99.851% when pulling 1cbb393 on therealartz:fix/fop-sequence-number into 991f4d4 on amabnl:master.

@DerMika
Copy link
Collaborator

DerMika commented Mar 20, 2018

I would prefer if (!is_null($options->sequenceNr)) instead of isset, because the option should always be set in the request options object.

@DerMika DerMika changed the title Fop sequence number check changed FOP_CreateFormOfPayment allow sequence number 0 Mar 20, 2018
@DerMika DerMika merged commit d110a68 into amabnl:master Mar 20, 2018
@DerMika DerMika added the bug label Mar 20, 2018
@DerMika
Copy link
Collaborator

DerMika commented Mar 20, 2018

Thanks for contributing!

@therealartz therealartz deleted the fix/fop-sequence-number branch March 21, 2018 09:48
@DerMika DerMika added this to the 1.7.0 milestone Mar 31, 2018
DerMika added a commit that referenced this pull request Mar 31, 2018
@DerMika
Copy link
Collaborator

DerMika commented Apr 30, 2018

Version 1.7.0 has just been released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants