-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error with not well formed Auth header #15
Conversation
* lowercase node names * wrong secure node name (was SessionId, but needed Session)
Changes Unknown when pulling e8e9be9 on smgladkovskiy:soap-2-session-headers into * on amabnl:develop*. |
1 similar comment
Changes Unknown when pulling e8e9be9 on smgladkovskiy:soap-2-session-headers into * on amabnl:develop*. |
Hi, First of all, thanks a lot! You're probably the first using the Soap Header 2 implementation, because I've been unable to obtain a WSAP for Soap Header 2 to actually test my code. With these changes, are you now able to send messages with a Soap Header 2 WSAP? |
And I'm going to use your code (pretty well-written, by the way) to implement connection to Amadeus Web Services in my project. So if something will be wrong my crew and I will help you to maintain and improve your code! ;)
Yeap! Sessions now work flawlessly. |
By the way! On develop branch you didn't update code usage examples for authentication routine. Is there more places where docs are so outdated? |
I'm not sure what you mean. I have both a Soap Header 4 and a Soap Header 2 example on https://github.com/amabnl/amadeus-ws-client/blob/develop/docs/about-get-started.rst#set-up-a-test-client - is anything missing? Please open an issue or submit a pull request if you feel that there's documentation missing - or wrong! |
…N-456-service.amadeus-search-prevent-warning to master * commit '676325f94aa5637069531cd8c089f99dc77374bd': VAN-456 service.amadeus / search / prevent warning on invalid inputs updated validator updated request handling updated test
Hi.
I tried to use develop branch to make some requests and faced with auth problems:
first:
after fixing first one:
on any request.
After some investigations I figured out the problems. I made some changes which allows to run the code without errors.
P.S. Tests are ignores the problems, so my changes didn't influenced on its greens.