Fare_PricePNRWithBookingClass add optionDetail to pricingOptionKey (#217

) * Add overrideOptionsWithCriteria for Fare
amabnl · Aug 4, 2018 · 4c246c5 · 4c246c5
1 parent 0447dcb
commit 4c246c5
Show file tree

Hide file tree

Showing 6 changed files with 87 additions and 1 deletion.
diff --git a/src/Amadeus/Client/RequestOptions/FarePricePnrWithBookingClassOptions.php b/src/Amadeus/Client/RequestOptions/FarePricePnrWithBookingClassOptions.php
@@ -123,6 +123,12 @@ class FarePricePnrWithBookingClassOptions extends Base
      */
     public $overrideOptions = [];
 
+
+    /**
+     * @var array
+     */
+    public $overrideOptionsWithCriteria = [];
+
     /**
      * Specify the validating carrier
      *

diff --git a/src/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass12.php b/src/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass12.php
@@ -168,6 +168,10 @@ protected function checkUnsupportedOptions($options)
         if (!empty($options->pricingLogic)) {
             throw new OptionNotSupportedException('Pricing Logic option not supported in version 12 or lower');
         }
+
+        if (!empty($options->overrideOptionsWithCriteria)) {
+            throw new OptionNotSupportedException('Override Options With Criteria are not supported in version 12 or lower');
+        }
     }
 
     /**

diff --git a/src/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass13.php b/src/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass13.php
@@ -171,6 +171,11 @@ public static function loadPricingOptionsFromRequestOptions($options)
             self::makeOverrideOptions($options->overrideOptions, $priceOptions)
         );
 
+        $priceOptions = self::mergeOptions(
+            $priceOptions,
+            self::makeOverrideOptionsWithCriteria($options->overrideOptionsWithCriteria, $priceOptions)
+        );
+
         // All options processed, no options found:
         if (empty($priceOptions)) {
             $priceOptions[] = new PricingOptionGroup(PricingOptionKey::OPTION_NO_OPTION);
@@ -197,6 +202,24 @@ protected static function makeOverrideOptions($overrideOptions, $priceOptions)
         return $opt;
     }
 
+    /**
+     * @param string[] $overrideOptionsWithCriteria
+     * @param PricingOptionGroup[] $priceOptions
+     * @return PricingOptionGroup[]
+     */
+    protected static function makeOverrideOptionsWithCriteria($overrideOptionsWithCriteria, $priceOptions)
+    {
+        $opt = [];
+
+        foreach ($overrideOptionsWithCriteria as $overrideOptionWithCriteria) {
+            if (!self::hasPricingGroup($overrideOptionWithCriteria["key"], $priceOptions)) {
+                $opt[] = new PricingOptionGroup($overrideOptionWithCriteria["key"], $overrideOptionWithCriteria["optionDetail"]);
+            }
+        }
+
+        return $opt;
+    }
+
     /**
      * @param string|null $validatingCarrier
      * @return PricePnr13\PricingOptionGroup[]

diff --git a/src/Amadeus/Client/Struct/Fare/PricePnr13/PricingOptionGroup.php b/src/Amadeus/Client/Struct/Fare/PricePnr13/PricingOptionGroup.php
@@ -94,9 +94,13 @@ class PricingOptionGroup
      * PricingOptionGroup constructor.
      *
      * @param string $key
+     * @param string $optionDetail
      */
-    public function __construct($key)
+    public function __construct($key, $optionDetail=null)
     {
         $this->pricingOptionKey = new PricingOptionKey($key);
+        if (isset($optionDetail)) {
+            $this->optionDetail = new OptionDetail($optionDetail);
+        }
     }
 }
diff --git a/tests/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass12Test.php b/tests/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass12Test.php
@@ -145,6 +145,25 @@ public function testCanThrowExceptioWhenDoPricePnrCallWithPricingLogic()
         new PricePNRWithBookingClass12($opt);
     }
 
+    public function testCanThrowExceptioWhenDoPricePnrCallWithOverrideOptionsWithCriteria()
+    {
+        $this->setExpectedException(
+            '\Amadeus\Client\Struct\OptionNotSupportedException',
+            'Override Options With Criteria are not supported in version 12 or lower'
+        );
+
+        $opt = new FarePricePnrWithBookingClassOptions([
+            'overrideOptionsWithCriteria' => [
+                [
+                    'key' => 'SBF',
+                    'optionDetail' => '1'
+                ]
+            ]
+        ]);
+
+        new PricePNRWithBookingClass12($opt);
+    }
+
     public function testCanDoPricePnrCallWithCorpNegoFare()
     {
         $opt = new FarePricePnrWithBookingClassOptions([

diff --git a/tests/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass13Test.php b/tests/Amadeus/Client/Struct/Fare/PricePNRWithBookingClass13Test.php
@@ -135,6 +135,36 @@ public function testCanDoPricePnrCallWithNewFareBasisParams()
         $this->assertTrue($this->assertArrayContainsSameObject($msg->pricingOptionGroup, $negofarePo));
     }
 
+    public function testCanDoPricePnrCallWithOverrideOptionWithCriteriaParams()
+    {
+        $opt = new FarePricePnrWithBookingClassOptions([
+            'validatingCarrier' => 'BA',
+            'currencyOverride' => 'EUR',
+            'overrideOptionsWithCriteria' => [
+                [
+                    'key' => 'SBF',
+                    'optionDetail' => '1'
+                ]
+            ]
+        ]);
+
+        $msg = new PricePNRWithBookingClass13($opt);
+
+        $validatingCarrierPo = new PricingOptionGroup(PricingOptionKey::OPTION_VALIDATING_CARRIER);
+        $validatingCarrierPo->carrierInformation = new CarrierInformation('BA');
+
+        $this->assertTrue($this->assertArrayContainsSameObject($msg->pricingOptionGroup, $validatingCarrierPo));
+
+        $currencyOverridePo = new PricingOptionGroup(PricingOptionKey::OPTION_FARE_CURRENCY_OVERRIDE);
+        $currencyOverridePo->currency = new Currency('EUR');
+
+        $this->assertTrue($this->assertArrayContainsSameObject($msg->pricingOptionGroup, $currencyOverridePo));
+
+        $negofarePo = new PricingOptionGroup('SBF','1');
+
+        $this->assertTrue($this->assertArrayContainsSameObject($msg->pricingOptionGroup, $negofarePo));
+    }
+
     public function testCanDoPricePnrCallWithNoOptions()
     {
         $opt = new FarePricePnrWithBookingClassOptions();