Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client_core): 🐛 Workaround for blank right eye view #2397

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

zmerp
Copy link
Member

@zmerp zmerp commented Sep 13, 2024

This is a workaround for a weird graphics bug. It seems the staging framebuffer cannot write to more than the size of the stream framebuffer, even if they have nothing to do with each other. The fix is to split the staging texture into two so each staging framebuffer has the same size as the stream framebuffers.

This bug has been investigated extensively .This is not a problem with shaders or viewports. The root cause is still unknown.

@The-personified-devil
Copy link
Collaborator

I'd still rather figure out the root cause as that could prevent future bugs, but debugging it seems hard and this should be good regardless.

@The-personified-devil The-personified-devil linked an issue Sep 14, 2024 that may be closed by this pull request
@zmerp zmerp merged commit a7a6e8e into master Sep 14, 2024
9 checks passed
@zmerp zmerp deleted the fix-blank-right-eye branch September 14, 2024 21:37
@zmerp zmerp mentioned this pull request Sep 20, 2024
@nowak-pl
Copy link

Root cause is enabled scissor test (https://www.khronos.org/opengl/wiki/Scissor_Test).
Add gl.disable(gl::SCISSOR_TEST); after

ck!(gl.viewport(0, 0, self.viewport_size.x, self.viewport_size.y));

or better yet store current state, disable and later reenable.

@zmerp
Copy link
Member Author

zmerp commented Sep 25, 2024

@nowak-pl Ah, were you able to test that? Would you like to make a PR or should we do it? I will not revert this PR for now, as the changes here contribute for future support for sliced encoding.

@nowak-pl
Copy link

All I can say is simple disable works me - didn't test if something else breaks because it expects scissors enabled.

zmerp added a commit that referenced this pull request Sep 27, 2024
This bug was already mitigated on #2397 but this is the proper fix. Discovered by @nowak-pl
zmerp added a commit that referenced this pull request Sep 28, 2024
This bug was already mitigated on #2397 but this is the proper fix. Discovered by @nowak-pl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

foveated encoding off --> right eye shows a black image
3 participants