Added argument check and corresponding node runner test for the get_s…

…hape method (openvinotoolkit#23637) This Fixes openvinotoolkit#23441 issue. Details: 1. Modified get_shape() method to report error in case any argument is passed. 2. Added Required Tests for the above in `tensor.test.js`. --------- Co-authored-by: Vishniakov Nikolai <[email protected]> Co-authored-by: Alicja Miloszewska <[email protected]>
alvoron · Apr 29, 2024 · 014d19c · 014d19c
1 parent f8cf5b3
commit 014d19c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/bindings/js/node/src/tensor.cpp b/src/bindings/js/node/src/tensor.cpp
@@ -133,6 +133,10 @@ Napi::Value TensorWrap::get_data(const Napi::CallbackInfo& info) {
 }
 
 Napi::Value TensorWrap::get_shape(const Napi::CallbackInfo& info) {
+    if (info.Length() > 0) {
+        reportError(info.Env(), "No parameters are allowed for the getShape() method.");
+        return info.Env().Undefined();
+    }
     return cpp_to_js<ov::Shape, Napi::Array>(info, _tensor.get_shape());
 }
 

diff --git a/src/bindings/js/node/tests/tensor.test.js b/src/bindings/js/node/tests/tensor.test.js
@@ -120,6 +120,14 @@ describe('Tensor shape', () => {
       /Cannot convert argument./
     );
   });
+
+  it('getShape() method does not accept parameters', () => {
+    const tensor = new ov.Tensor(ov.element.f32, [1, 3, 224, 224], data);
+    assert.throws(
+      () => tensor.getShape(1, 2, 3),
+      { message: 'No parameters are allowed for the getShape() method.'}
+    );
+  });
 });
 
 describe('Tensor element type', () => {