wallets: Don't wait for subprocess shutdown after response

We send a `stop` RPC call and wait for the subprocess after receiving a `success/ok` message. This is unnecessary because we received a `success` reply already.
alvasw · Sep 3, 2024 · 2b5e36e · 2b5e36e
1 parent b2233ef
commit 2b5e36e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 32 deletions.
diff --git a/wallets/core/src/main/java/bisq/wallets/core/exceptions/WalletShutdownFailedException.java b/wallets/core/src/main/java/bisq/wallets/core/exceptions/WalletShutdownFailedException.java
diff --git a/wallets/process/src/main/java/bisq/wallets/process/DaemonProcess.java b/wallets/process/src/main/java/bisq/wallets/process/DaemonProcess.java
@@ -19,7 +19,6 @@
 
 import bisq.common.file.FileUtils;
 import bisq.common.file.LogScanner;
-import bisq.wallets.core.exceptions.WalletShutdownFailedException;
 import bisq.wallets.core.exceptions.WalletStartupFailedException;
 import lombok.Getter;
 import lombok.extern.slf4j.Slf4j;
@@ -58,13 +57,7 @@ public void start() {
 
     @Override
     public void shutdown() {
-        try {
-            invokeStopRpcCall();
-            process.waitFor(2, TimeUnit.MINUTES);
-        } catch (InterruptedException e) {
-            String processName = process.info().command().orElse("<unknown process>");
-            throw new WalletShutdownFailedException("Cannot shutdown " + processName + ".", e);
-        }
+        invokeStopRpcCall();
     }
 
     private void waitUntilReady() {