-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit db refactor #824
Merged
Merged
Exit db refactor #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptulugu
force-pushed
the
pranay/refactor
branch
5 times, most recently
from
August 23, 2023 20:40
15fa1a1
to
f2cbde7
Compare
ptulugu
force-pushed
the
pranay/refactor
branch
2 times, most recently
from
August 28, 2023 20:30
6c35728
to
a341d54
Compare
ptulugu
force-pushed
the
pranay/refactor
branch
4 times, most recently
from
September 13, 2023 18:57
c17b5d3
to
98907d3
Compare
jkilpatr
requested changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this is a big one!
I've left some comments, mostly about duplicated code that should be de-duplicated and cleaned up into utility functions.
Looks like clippy still needs fixing along with the CI tests not completing
ptulugu
force-pushed
the
pranay/refactor
branch
5 times, most recently
from
September 15, 2023 18:37
e8513ef
to
ae9d16a
Compare
jkilpatr
approved these changes
Sep 15, 2023
ptulugu
force-pushed
the
pranay/refactor
branch
from
September 18, 2023 19:49
ae9d16a
to
3115275
Compare
jkilpatr
force-pushed
the
pranay/refactor
branch
from
September 19, 2023 20:58
3115275
to
d1a55ff
Compare
ptulugu
force-pushed
the
pranay/refactor
branch
3 times, most recently
from
September 20, 2023 22:33
e4a7ce6
to
944638c
Compare
…m exits The goal of this change is to make it possible for many thousands of exits to easily run off a single database with no shared credentials and also to make it possible for many different organizations to cooperate on this database. In order to achieve this we will be replacing the postgresql database currently used by the exits with a smart contract which will be used to register users Client register flow has changed from client -> Exit -> Ops. Exit forwards a request to an external server with sms api key in order to verify a client. That server will have write access to the smart contract to add the client, and then return their registration status to exit, which then forwards that request back to the client
AltheaDB.sol is the solidity contract to be hosted on the althea blockchain that is used in place of the previous postgresql db. This commits add this contract as well as implementations of functions in rita_client_registration to add and query users to this contract
Since the register endpoint can be called simultaneously by multiple router, we need to queue up these txs and batch them together and setup the correct nonce
ptulugu
force-pushed
the
pranay/refactor
branch
from
September 20, 2023 22:34
944638c
to
bdc1394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to make it possible for many thousands of exits
to easily run off a single database with no shared credentials and also to
make it possible for many different organizations to cooperate on this database.
In order to achieve this we will be replacing the postgresql database currently
used by the exits with a smart contract which will be used to register users
Client register flow has changed from client -> Exit -> Ops. Exit forwards a request to an external server with sms api key in order to
verify a client. That server will have write access to the smart contract to add the client, and then return their registration status to
exit, which then forwards that request back to the client