Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing wifi device data #1032

Open
wants to merge 1 commit into
base: beta21
Choose a base branch
from
Open

Conversation

ch-iara
Copy link
Contributor

@ch-iara ch-iara commented Oct 31, 2024

Getting wifi iface names from 'uci show wireless' is no longer an option since these do not always get saved to config- and routers that were missing hard coded ifname config were not populating wifi devices to report to ops. Instead, 'iw dev' lists all interfaces for wifi and those ifnames can be more reliably accessed from there.

Getting wifi iface names from 'uci show wireless' is no longer an option
since these do not always get saved to config- and routers that were
missing hard coded ifname config were not populating wifi devices to
report to ops. Instead, 'iw dev' lists all interfaces for wifi and those
ifnames can be more reliably accessed from there.
@jkilpatr
Copy link
Member

Can you add a unit test for the parsing logic? Just break out the parsing from the calling of the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants