Fix runtime price-setting #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was an old name for the "fee" config value (used to be "price") which was included in a parser if statement which would exclude unrecognized keywords.
drozdziak1
force-pushed
the
15-runtime-price
branch
from
ce040fc
to
37c62c1
Compare
jkilpatr
approved these changes
Oct 25, 2018
drozdziak1
commented
Oct 25, 2018
| @@ -801,7 +801,7 @@ parse_option(int c, gnc_t gnc, void *closure, char *token) | |||
| strcmp(token, "diversity") != 0 && | |||
| strcmp(token, "diversity-factor") != 0 && | |||
| strcmp(token, "smoothing-half-life") != 0 && | |||
| strcmp(token, "price") != 0) | |||
There was a problem hiding this comment.
FYI that's the crucial change, others are just improvements
mpapierski
reviewed
Oct 25, 2018
configuration.c
Outdated
| unsigned int i; | ||
| c = getword(c, &t, gnc, closure); | ||
| if(c < -1) | ||
| return c; | ||
| errno = 0; | ||
| i = strtoul(t, &end, 0); | ||
| if(*end != '\0' || errno) { | ||
| if(!t || t[0] == '-' || *end != '\0' || errno) { |
There was a problem hiding this comment.
I'm out of the context but why we're downcasting unsigned long into unsigned int? Would it be possible to keep the type?
drozdziak1
force-pushed
the
15-runtime-price
branch
from
5d8270c
to
bebc783
Compare
drozdziak1
force-pushed
the
15-runtime-price
branch
from
bebc783
to
6bc78ec
Compare
mpapierski
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "fee" config value
you can set the fee via the socket or a config file like so:
valuehas to be within uint32_t bounds.Yes, it was this simple [*]