Unpinned ipywidgets #4288
Merged
Unpinned ipywidgets #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4288 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 355 355
Lines 39154 39154
=====================================
Hits 39034 39034
Misses 120 120 |
remyogasawara
requested review from
eccabay,
jeremyliweishih,
christopherbunn,
fjlanasa,
MichaelFu512 and
chukarsten
eccabay
reviewed
Aug 28, 2023
| - ipywidgets >=7.5, <8.0.5 | ||
| - ipywidgets >=7.5 |
There was a problem hiding this comment.
Looks like ipywidgets must have fixed whatever was causing the errors we saw back in March, if we're able to unpin and have no tests fail. However, I think if a user happened to have ipywidgets v8.0.5 installed in the environment where they're installing evalml, the issues would still exist.
Could you install ipywidgets 8.0.5 and the following versions locally, to see if they still error? If so, we should exclude those specific versions.
There was a problem hiding this comment.
The tests passed for v.8.0.5-7 as well!
There was a problem hiding this comment.
👀 surprising, but glad it'll work 🚢
jeremyliweishih
approved these changes
Aug 28, 2023
eccabay
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4099