Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CODECOV_TOKEN to in-repo builds #42

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

altendky
Copy link
Owner

Might help with #38

Note that secrets do not get exposed to out-of-repository PRs. We'll see if this is sufficient to sort out the issue. If not, we can just put the token in the repository. Bad actors uploading bogus coverage reports isn't the most scary attack vector ever.

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #42 (c5406e5) into main (f9c0c49) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          595       595           
  Branches        43        43           
=========================================
  Hits           595       595           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c0c49...c5406e5. Read the comment docs.

@altendky
Copy link
Owner Author

It appears that the token usage can be noted via the log.

--> token set from env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant