Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QSelect] accessibility navigation #49

Merged
merged 8 commits into from
Jan 27, 2021
Merged

Conversation

cheesytim
Copy link
Member

No description provided.

src/qComponents/QSelect/src/QSelectTags.vue Outdated Show resolved Hide resolved
src/qComponents/QOption/src/q-option.scss Outdated Show resolved Hide resolved
src/qComponents/QOption/src/q-option.scss Outdated Show resolved Hide resolved
src/qComponents/QSelect/src/QSelect.vue Outdated Show resolved Hide resolved
src/qComponents/QSelect/src/QSelect.vue Outdated Show resolved Hide resolved
src/qComponents/QSelect/src/QSelectDropdown.vue Outdated Show resolved Hide resolved
src/qComponents/QSelect/src/QSelectDropdown.vue Outdated Show resolved Hide resolved
@cheesytim cheesytim requested a review from ViZhe January 26, 2021 14:35
@@ -65,6 +65,12 @@ export default {
},

methods: {
handleBackspaceKeyDown() {
if (this.query.length === 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!this.query

src/qComponents/index.js Show resolved Hide resolved
@cheesytim cheesytim merged commit 6980985 into master Jan 27, 2021
@cheesytim cheesytim deleted the select-accessibility branch January 27, 2021 07:23
@cheesytim cheesytim linked an issue Feb 8, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider adding better focus states for keyboard users
2 participants