Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto3: add optional support #65

Merged
merged 1 commit into from
Sep 27, 2021
Merged

proto3: add optional support #65

merged 1 commit into from
Sep 27, 2021

Conversation

Adphi
Copy link
Contributor

@Adphi Adphi commented Sep 27, 2021

closes #64

ydnar
ydnar requested changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@ydnar ydnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to make protos to regenerate!

tests/message/message_test.go Outdated Show resolved Hide resolved
tests/message/message_renames.proto Outdated Show resolved Hide resolved
@Adphi Adphi requested a review from ydnar September 27, 2021 15:28
ydnar
ydnar approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@ydnar ydnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a line to CHANGELOG in this PR that follows the existing format linking to this PR?

@Adphi Adphi requested a review from ydnar September 27, 2021 16:38
ydnar
ydnar reviewed Sep 27, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ydnar
ydnar reviewed Sep 27, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@Adphi Adphi requested a review from ydnar September 27, 2021 18:00
@ydnar ydnar merged commit 7947490 into alta:main Sep 27, 2021
@Adphi Adphi deleted the optional branch November 17, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydnar ydnar ydnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proto3: add optional support
2 participants
@Adphi @ydnar