Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle linted enum values from imported protos #41

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Handle linted enum values from imported protos #41

merged 3 commits into from
Mar 11, 2021

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Mar 11, 2021

Fixes #40.

ydnar added 2 commits March 11, 2021 15:36
@ydnar
tests/lint: add test for imported enum value
0a69ffd 
This is a test case to verify the bug in #40.
@ydnar
patch: remove optimization for renamed enum values
477da08 
This fixes using imported enum values renamed with (go.lint).all. Fixes #40.
@ydnar ydnar self-assigned this Mar 11, 2021
@ydnar ydnar merged commit 5bb12fb into main Mar 11, 2021
@ydnar ydnar deleted the ydnar/40 branch March 11, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ydnar ydnar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

option (go.lint).all = true; does not work for enum values imported from other package
1 participant
@ydnar