customize json tag

[liov]

No description provided.

[ydnar]

Thanks for the pull request. We’re probably not going to merge it, but I appreciate the PR.

Since there wasn’t a description in the PR, I’m trying to guess at what the purpose is. Why have a separate json_tags option when tags can be used to specify the json tags for a struct field?

Second, the PR renames the package and module from alta to liov. All of these would need to be backed out and rebased/squashed before we consider merging this.

Note: you don’t need to rename a a Go module or package to work on a fork of it. You can just use a replace directive in the go.mod file to point a module at a local directory or fork:

https://thewebivore.com/using-replace-in-go-mod-to-point-to-your-local-module/

[liov]

Sorry, I found that the tags option cannot generate custom json tags, so I wrote a json_tag tag myself, and later changed the package name because I think this PR will not be merged for the time being and I want to use it for my own project

[ydnar]

I see. I'd accept a pull request that allows the tags directive to override the json tag.

[liov]

I think I understand what you mean

[liov]

now,the tags directive to override the json tag.But I reset the branch and forced push it, I don’t know if this is a valid PR

[ydnar]

OK. Now it needs tests!

[liov]

I think the tags order is not very important

[ydnar]

Thanks!

I’d love to see the new logic extract into a simple helper function that can have its own unit tests, ala:

func mergeTags(tags, newTags string) string {
        ...
}

[ydnar]

The test rewrites look terrific, thank you!

[ydnar]

Hi @liov! Thanks for the updates in the last commit.

Would it make sense to import and use this package instead of reimplementing it here? https://pkg.go.dev/github.com/fatih/structtag

[ydnar]

Well, shoot.

https://twitter.com/go100and1/status/1333773730519031808?s=21

[ydnar]

Superseded by #31. Thanks @liov!