Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom languages #168

Merged
merged 6 commits into from
Jan 1, 2024
Merged

Conversation

Christoph-Koschel
Copy link
Contributor

Finally, after the rough semester start, I found some time to work on this feature.

@Christoph-Koschel
Copy link
Contributor Author

Note: In my last commit, I changed the test URL to the main repo. However, the testing file does not exist in the main repo because it will be "created" through my PR. Therefore, the test is failing.

@alstr
Copy link
Owner

alstr commented Oct 13, 2023

Thanks very much for the contribution, I'll aim to take a look over this as soon as I can.

PS, if it helps, there was an attempt at this previously, and it was almost complete: #105

@alstr alstr changed the title Add support for costume languages Add support for custom languages Oct 13, 2023
@Christoph-Koschel
Copy link
Contributor Author

Hey, it's been a few months and I wanted to know if the PR is still under review

@alstr
Copy link
Owner

alstr commented Dec 31, 2023

Thanks for your patience and sorry for the delay, I've just not had chance until now.

It all seems good. I've not tested it myself; does it run okay for you?

One small thing, would you be able to replace 'costume' with 'custom'? I'm assuming that's what you meant and it's not a big deal, just makes things easier in future! 😄

Thanks.

@Christoph-Koschel
Copy link
Contributor Author

I have fixed the typo. Also loading costume languages works like a charm. I also wrote some unit tests, so I think it should work smoothly.

@alstr alstr merged commit 80f1c09 into alstr:master Jan 1, 2024
1 check failed
@alstr
Copy link
Owner

alstr commented Jan 1, 2024

I've merged it and created a new release so you should be good to try it out. I had to slightly change a URL in the tests but other than that the tests seem to be running fine. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants