Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GDScript #136

Merged
merged 2 commits into from
Dec 22, 2022
Merged

added GDScript #136

merged 2 commits into from
Dec 22, 2022

Conversation

0xd011f4ce
Copy link
Contributor

Hello alstr!
I added the GDScript programming language. I hope everything is alright with this. If there's anything wrong that I have to fix, please let me know, and I'll fix it asap.

@alstr
Copy link
Owner

alstr commented Dec 15, 2022

Hey, thanks for the contribution. Looks like the tests are failing at the moment, and it also seems to have thrown out the Org tests.

I think it's because the tests should be checking for text not GDScript, as that is the ace_mode for this language: https://github.com/github/linguist/blob/c1c34e5260797b4d598f5ec76f19723bfc5a1894/lib/linguist/languages.yml#L2098

As Org has the same ace_mode, you can just remove the new tests and increment the existing Org tests (feel free to rename the tests).

Hope that makes sense. Should probably look at making this clearer at some point.

@0xd011f4ce
Copy link
Contributor Author

Ohhh yeah, I didn't notice that, it works now! All tests are passing.

@alstr alstr merged commit 8c572e1 into alstr:master Dec 22, 2022
@alstr
Copy link
Owner

alstr commented Dec 22, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants