[Tweak] Add bottom padding to project card #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshedivat
approved these changes
Jun 8, 2024
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
## Current Behavior ### Vertical 👎 There is _no_ space between cards in the vertical project layout <img width="400" alt="v1-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/c97b558d-dc10-4b1f-9547-51e1710c82d3"> <br> ### Horizontal 👍 Card spacing already looks good in horizontal layout <img width="350" alt="v1-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/1548766b-41ab-447a-ba35-fdb45ff92545"> ## Proposed Resolution **Simplistic** resolution: add padding to card's bottom (in both vertical and horizontal project layout) <img width="400" alt="v2-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/739eef5d-077f-46b7-a99a-52c6a82c5515"> <img width="350" alt="v2-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/ba1e8269-193b-4151-b7af-915ace97d240">
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
## Current Behavior ### Vertical 👎 There is _no_ space between cards in the vertical project layout <img width="400" alt="v1-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/c97b558d-dc10-4b1f-9547-51e1710c82d3"> <br> ### Horizontal 👍 Card spacing already looks good in horizontal layout <img width="350" alt="v1-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/1548766b-41ab-447a-ba35-fdb45ff92545"> ## Proposed Resolution **Simplistic** resolution: add padding to card's bottom (in both vertical and horizontal project layout) <img width="400" alt="v2-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/739eef5d-077f-46b7-a99a-52c6a82c5515"> <img width="350" alt="v2-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/ba1e8269-193b-4151-b7af-915ace97d240">
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this pull request
Oct 13, 2024
## Current Behavior ### Vertical 👎 There is _no_ space between cards in the vertical project layout <img width="400" alt="v1-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/c97b558d-dc10-4b1f-9547-51e1710c82d3"> <br> ### Horizontal 👍 Card spacing already looks good in horizontal layout <img width="350" alt="v1-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/1548766b-41ab-447a-ba35-fdb45ff92545"> ## Proposed Resolution **Simplistic** resolution: add padding to card's bottom (in both vertical and horizontal project layout) <img width="400" alt="v2-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/739eef5d-077f-46b7-a99a-52c6a82c5515"> <img width="350" alt="v2-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/ba1e8269-193b-4151-b7af-915ace97d240">
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this pull request
Oct 22, 2024
## Current Behavior ### Vertical 👎 There is _no_ space between cards in the vertical project layout <img width="400" alt="v1-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/c97b558d-dc10-4b1f-9547-51e1710c82d3"> <br> ### Horizontal 👍 Card spacing already looks good in horizontal layout <img width="350" alt="v1-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/1548766b-41ab-447a-ba35-fdb45ff92545"> ## Proposed Resolution **Simplistic** resolution: add padding to card's bottom (in both vertical and horizontal project layout) <img width="400" alt="v2-vertical" src="https://github.com/rstein66/al-folio/assets/5504473/739eef5d-077f-46b7-a99a-52c6a82c5515"> <img width="350" alt="v2-horizontal" src="https://github.com/rstein66/al-folio/assets/5504473/ba1e8269-193b-4151-b7af-915ace97d240">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Vertical 👎
There is no space between cards in the vertical project layout
Horizontal 👍
Card spacing already looks good in horizontal layout
Proposed Resolution
Simplistic resolution: add padding to card's bottom (in both vertical and horizontal project layout)