Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline leaflet #2420

Merged
merged 4 commits into from
May 15, 2024
Merged

Fix offline leaflet #2420

merged 4 commits into from
May 15, 2024

Conversation

george-gca
Copy link
Collaborator

Fixes #2419 by downloading leaflet images. Also changed the path where the libraries are downloaded to avoid not downloading files with same name.

@CheariX
Copy link
Contributor

CheariX commented May 15, 2024

I'm wondering how the images can downloaded beforehand?
I assume that only the initial images are downloaded but when you scroll the map, there will be missing images?

@gockar
Copy link

gockar commented May 15, 2024

I'm wondering how the images can downloaded beforehand? I assume that only the initial images are downloaded but when you scroll the map, there will be missing images?

Sorry for the confusion, I was referring to the static graphics for markers etc. that are delivered together (or not...) with the JS and CSS. Downloading all the maps could quickly become a lot. The source can be selected individually and they are downloaded dynamically.

@george-gca
Copy link
Collaborator Author

george-gca commented May 15, 2024

Yes, there is so much we can do about offline support. Check if it is working now @gockar.

@gockar
Copy link

gockar commented May 15, 2024

Sorry, wanted to point out that all the maps themselves should not be downloaded as they consume an extreme amount of memory. My problems are solved with the changes, thank you!

@george-gca george-gca merged commit e954d77 into alshedivat:master May 15, 2024
3 checks passed
@george-gca george-gca deleted the missing_hashes branch May 15, 2024 20:56
george-gca added a commit to george-gca/multi-language-al-folio that referenced this pull request May 17, 2024
Fixes alshedivat#2419 by downloading leaflet images. Also changed the path where
the libraries are downloaded to avoid not downloading files with same
name.

---------

Signed-off-by: George Araujo <[email protected]>
siril-teja pushed a commit to siril-teja/siril-teja.github.io-old that referenced this pull request Jun 19, 2024
Fixes alshedivat#2419 by downloading leaflet images. Also changed the path where
the libraries are downloaded to avoid not downloading files with same
name.

---------

Signed-off-by: George Araujo <[email protected]>
karapostK pushed a commit to karapostK/karapostK.github.io that referenced this pull request Jul 4, 2024
Fixes alshedivat#2419 by downloading leaflet images. Also changed the path where
the libraries are downloaded to avoid not downloading files with same
name.

---------

Signed-off-by: George Araujo <[email protected]>
Suraj-Bhor pushed a commit to Suraj-Bhor/suraj-bhor.github.io that referenced this pull request Aug 13, 2024
Fixes alshedivat#2419 by downloading leaflet images. Also changed the path where
the libraries are downloaded to avoid not downloading files with same
name.

---------

Signed-off-by: George Araujo <[email protected]>
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
Fixes alshedivat#2419 by downloading leaflet images. Also changed the path where
the libraries are downloaded to avoid not downloading files with same
name.

---------

Signed-off-by: George Araujo <[email protected]>
avishekanand pushed a commit to avishekanand/al-folio-homepage that referenced this pull request Oct 22, 2024
Fixes alshedivat#2419 by downloading leaflet images. Also changed the path where
the libraries are downloaded to avoid not downloading files with same
name.

---------

Signed-off-by: George Araujo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaflet issues in offline mode
4 participants