Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amd-soundwire: add support for AMD generic legacy machine driver #478

Closed
wants to merge 1 commit into from

Conversation

perexg
Copy link
Member

@perexg perexg commented Nov 29, 2024

The card components string is similar to Intel's SOF driver like, so we can reuse sof-soundwire configuration and it is logical to reduce future maintenance, because the chips connected to soundwire bus are similar for multiple PCI bridges.

Example of the components string:

Components : ' cfg-amp:1 hs:rt722 spk:rt722 mic:rt722'

@vijendarmukunda
Copy link

@perexg : I do have further question. Today we haven't included support for SoundWire + ACP PDM IO combination. As we are referring common soundwire conf file , for AMD platforms ACP PDM IO is different compared to Intel PCH DMIC . How it is going to be addressed?
We do have another question. Going forward we will add support for SOF Sound card for AMD platforms . If we refer common config files, how the delta between AMD & Intel platforms can be handled?

@vijendarmukunda
Copy link

Tested the PR. With this PR changes , Input device is not listed in Sound Settings

@vijendarmukunda
Copy link

@shumingfan : Could you please validate this PR changes and confirm the test result?

@perexg
Copy link
Member Author

perexg commented Dec 2, 2024

Tested the PR. With this PR changes , Input device is not listed in Sound Settings

Provide dump alsaucm -c hw:0 dump text - replace zero with the proper ALSA card number.

for AMD platforms ACP PDM IO is different compared to Intel PCH DMIC . How it is going to be addressed?

We have conditions to handle differences. But, as you can already see, most configurations are related to the soundwire codecs - not DMA drivers.

@vijendarmukunda
Copy link

amd-soundwire.zip
Attached amd-soundwire conf file for your reference.

When i run the command , with syntax 7 I got below error.

root@amd:/home/amd# alsaucm -c hw:1 dump text
ALSA lib parser.c:270:(parse_syntax_field) Incompatible syntax 7 in amd-soundwire.conf
ALSA lib main.c:1554:(snd_use_case_mgr_open) error: failed to import hw:1 use case configuration -22
alsaucm: error failed to open sound card hw:1: Invalid argument

Then I have changes syntax as 6 in amd-soundwire.conf file and tried to collect ucm dump.
I got below error.

root@amd:/home/amd# alsaucm -c hw:1 dump text
ALSA lib utils.c:364:(uc_mgr_config_load_into) could not open configuration file /usr/share/alsa/ucm2/common/pcm/hdmi.conf
ALSA lib parser.c:78:(uc_mgr_config_load_file) error: failed to open file /usr/share/alsa/ucm2/common/pcm/hdmi.conf: -2
ALSA lib main.c:1554:(snd_use_case_mgr_open) error: failed to import hw:1 use case configuration -2
alsaucm: error failed to open sound card hw:1: No such file or directory

@perexg
Copy link
Member Author

perexg commented Dec 2, 2024

@vijendarmukunda
Copy link

@perexg : Back ported changes to our UCM base. It's working fine. Able to list the audio endpoints correctly.

@perexg perexg closed this in 0782bf4 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants