Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpstable#400 update decode pipeline #401

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

prestonvasquez
Copy link
Contributor

@prestonvasquez prestonvasquez commented Mar 3, 2023

Resolves #400

This update removed the "Decode" function from the exported API in favor of a functional pattern for decoding based on the application/content-type. The new method for decoding an HTTP response body was given a minor optimization:

Before:

goos: darwin
goarch: arm64
pkg: github.com/alpstable/gidari
BenchmarkDecodeUpsertRequest-10             1203            927933 ns/op          314197 B/op      10059 allocs/op

After:

goos: darwin
goarch: arm64
pkg: github.com/alpstable/gidari
BenchmarkDecodeUpsertRequest-10             5685            219681 ns/op          378087 B/op      10070 allocs/op

@prestonvasquez prestonvasquez merged commit f64fb53 into alpstable:main Mar 3, 2023
@prestonvasquez prestonvasquez deleted the alpstable#400 branch March 3, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve JSON response body as a stream of data
1 participant