Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Allows model.fill to work with checkbox arrays #3676

Merged
merged 1 commit into from
Jul 24, 2023
Merged

bug: Allows model.fill to work with checkbox arrays #3676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/alpinejs/src/directives/x-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,10 @@ directive('model', (el, { modifiers, expression }, { effect, cleanup }) => {
setValue(getInputValue(el, modifiers, e, getValue()))
})

if (modifiers.includes('fill') && [null, ''].includes(getValue())) {
el.dispatchEvent(new Event(event, {}));
if (modifiers.includes('fill'))
if ([null, ''].includes(getValue())
|| (el.type === 'checkbox' && Array.isArray(getValue()))) {
el.dispatchEvent(new Event(event, {}));
}
// Register the listener removal callback on the element, so that
// in addition to the cleanup function, x-modelable may call it.
Expand Down
13 changes: 12 additions & 1 deletion tests/cypress/integration/directives/x-model.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,5 +186,16 @@ test('x-model with fill modifier respects number modifier',
}
);


test(
'x-model with fill applies on checkboxes bound to array',
html`
<div x-data="{ a: ['456'] }">
<input type="checkbox" x-model.fill="a" value="123" checked />
<input type="checkbox" x-model.fill="a" value="456" />
</div>
`,
({ get }) => {
get('[x-data]').should(haveData('a', ['123']));
}
);