Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for WASM #249

Merged
merged 11 commits into from
Nov 17, 2021
Merged

Support for WASM #249

merged 11 commits into from
Nov 17, 2021

Conversation

alphaville
Copy link
Owner

@alphaville alphaville commented Nov 12, 2021 •
edited
Loading

Support for Wasm

Main Changes

  • Optional feature wasm in Cargo.toml
  • Using instant::Instant instead of std::Instant (Wasm-compatible)
  • Fixed Rust documentation of Ball1

Associated Issues

TODOs

  • Documentation
  • All tests must pass
  • Update CHANGELOG(s)
  • Update webpage documentation
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)

New Versions

  • OpEn v0.7.4

@alphaville
Cargo.toml: support for wasm
755acf0 
using optional feature
@alphaville alphaville added enhancement New feature or request rust issue related to the code Rust library labels Nov 12, 2021
@alphaville
Cargo: passing features down to dependencies
ba3a502 
using instant::Instant instead of std::Instant
@alphaville alphaville self-assigned this Nov 12, 2021
ruairimoran
ruairimoran approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruairimoran ruairimoran merged commit 80e760f into master Nov 17, 2021
@alphaville alphaville deleted the feature/248 branch February 8, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruairimoran ruairimoran ruairimoran approved these changes

Assignees

@alphaville alphaville

Labels
enhancement New feature or request rust issue related to the code Rust library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM Support
2 participants
@alphaville @ruairimoran