Merge pull request #365 from alphaville/hf/update-setup.py #427
Annotations
25 warnings
Rustfmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
the following explicit lifetimes could be elided: 'a:
src/core/panoc/panoc_engine.rs#L301
warning: the following explicit lifetimes could be elided: 'a
--> src/core/panoc/panoc_engine.rs:301:6
|
301 | impl<'a, GradientType, ConstraintType, CostType> AlgorithmEngine
| ^^
302 | for PANOCEngine<'a, GradientType, ConstraintType, CostType>
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
301 ~ impl<GradientType, ConstraintType, CostType> AlgorithmEngine
302 ~ for PANOCEngine<'_, GradientType, ConstraintType, CostType>
|
|
doc list item without indentation:
src/core/panoc/panoc_cache.rs#L161
warning: doc list item without indentation
--> src/core/panoc/panoc_cache.rs:161:9
|
161 | /// are satisfied.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
161 | /// are satisfied.
| +++
|
usage of a legacy numeric constant:
src/core/panoc/panoc_cache.rs#L75
warning: usage of a legacy numeric constant
--> src/core/panoc/panoc_cache.rs:75:29
|
75 | norm_gamma_fpr: std::f64::INFINITY,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
75 | norm_gamma_fpr: f64::INFINITY,
| ~~~~~~~~~~~~~
|
usage of a legacy numeric constant:
src/core/fbs/fbs_cache.rs#L46
warning: usage of a legacy numeric constant
--> src/core/fbs/fbs_cache.rs:46:23
|
46 | norm_fpr: std::f64::INFINITY,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
46 | norm_fpr: f64::INFINITY,
| ~~~~~~~~~~~~~
|
the following explicit lifetimes could be elided: 'a:
src/constraints/sphere2.rs#L20
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/sphere2.rs:20:6
|
20 | impl<'a> Constraint for Sphere2<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
20 - impl<'a> Constraint for Sphere2<'a> {
20 + impl Constraint for Sphere2<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/rectangle.rs#L47
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/rectangle.rs:47:6
|
47 | impl<'a> Constraint for Rectangle<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
47 - impl<'a> Constraint for Rectangle<'a> {
47 + impl Constraint for Rectangle<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/hyperplane.rs#L58
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/hyperplane.rs:58:6
|
58 | impl<'a> Constraint for Hyperplane<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
58 - impl<'a> Constraint for Hyperplane<'a> {
58 + impl Constraint for Hyperplane<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/halfspace.rs#L58
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/halfspace.rs:58:6
|
58 | impl<'a> Constraint for Halfspace<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
58 - impl<'a> Constraint for Halfspace<'a> {
58 + impl Constraint for Halfspace<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/finite.rs#L55
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/finite.rs:55:6
|
55 | impl<'a> Constraint for FiniteSet<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
55 - impl<'a> Constraint for FiniteSet<'a> {
55 + impl Constraint for FiniteSet<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/cartesian_product.rs#L130
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/cartesian_product.rs:130:6
|
130 | impl<'a> Constraint for CartesianProduct<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
130 - impl<'a> Constraint for CartesianProduct<'a> {
130 + impl Constraint for CartesianProduct<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/ballinf.rs#L23
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/ballinf.rs:23:6
|
23 | impl<'a> Constraint for BallInf<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
23 - impl<'a> Constraint for BallInf<'a> {
23 + impl Constraint for BallInf<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/ball2.rs#L21
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/ball2.rs:21:6
|
21 | impl<'a> Constraint for Ball2<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
21 - impl<'a> Constraint for Ball2<'a> {
21 + impl Constraint for Ball2<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
src/constraints/ball1.rs#L42
warning: the following explicit lifetimes could be elided: 'a
--> src/constraints/ball1.rs:42:6
|
42 | impl<'a> Constraint for Ball1<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
42 - impl<'a> Constraint for Ball1<'a> {
42 + impl Constraint for Ball1<'_> {
|
|
this function has too many arguments (9/7):
src/alm/alm_problem.rs#L135
warning: this function has too many arguments (9/7)
--> src/alm/alm_problem.rs:135:5
|
135 | / pub fn new(
136 | | constraints: ConstraintsType,
137 | | alm_set_c: Option<AlmSetC>,
138 | | alm_set_y: Option<LagrangeSetY>,
... |
144 | | n2: usize,
145 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
empty doc comment:
src/alm/alm_optimizer_status.rs#L22
warning: empty doc comment
--> src/alm/alm_optimizer_status.rs:22:5
|
22 | ///
| ^^^
|
= help: consider removing or filling it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
= note: `#[warn(clippy::empty_docs)]` on by default
|
usage of a legacy numeric constant:
src/alm/alm_optimizer.rs#L735
warning: usage of a legacy numeric constant
--> src/alm/alm_optimizer.rs:735:71
|
735 | .unwrap_or_else(|| std::time::Duration::from_secs(std::u64::MAX)),
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
735 | .unwrap_or_else(|| std::time::Duration::from_secs(u64::MAX)),
| ~~~~~~~~
|
usage of a legacy numeric constant:
src/alm/alm_optimizer.rs#L16
warning: usage of a legacy numeric constant
--> src/alm/alm_optimizer.rs:16:28
|
16 | const SMALL_EPSILON: f64 = std::f64::EPSILON;
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
16 | const SMALL_EPSILON: f64 = f64::EPSILON;
| ~~~~~~~~~~~~
|
this function has too many arguments (8/7):
src/alm/alm_factory.rs#L158
warning: this function has too many arguments (8/7)
--> src/alm/alm_factory.rs:158:5
|
158 | / pub fn new(
159 | | f: Cost,
160 | | df: CostGradient,
161 | | mapping_f1: Option<MappingF1>,
... |
166 | | n2: usize,
167 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
usage of a legacy numeric constant:
src/alm/alm_cache.rs#L82
warning: usage of a legacy numeric constant
--> src/alm/alm_cache.rs:82:27
|
82 | f2_norm_plus: std::f64::INFINITY,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
82 | f2_norm_plus: f64::INFINITY,
| ~~~~~~~~~~~~~
|
usage of a legacy numeric constant:
src/alm/alm_cache.rs#L80
warning: usage of a legacy numeric constant
--> src/alm/alm_cache.rs:80:32
|
80 | delta_y_norm_plus: std::f64::INFINITY,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
|
80 | delta_y_norm_plus: f64::INFINITY,
| ~~~~~~~~~~~~~
|