Notifications - PR notes, take3

Signed-off-by: Amit Prinz Setter <[email protected]>
alphaprinz · Nov 17, 2024 · b514682 · b514682
1 parent f36d0bb
commit b514682
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/deploy/crds/noobaa.io_noobaas.yaml b/deploy/crds/noobaa.io_noobaas.yaml
@@ -1061,6 +1061,8 @@ spec:
                       for holding pending notifications files.
                       For ODF - If not provided, the default CepthFS storage class will be used to create the PVC.
                     type: string
+                required:
+                - enabled
                 type: object
               cleanupPolicy:
                 description: CleanupPolicy (optional) Indicates user's policy for

diff --git a/pkg/apis/noobaa/v1alpha1/noobaa_types.go b/pkg/apis/noobaa/v1alpha1/noobaa_types.go
@@ -265,7 +265,7 @@ type BucketLoggingSpec struct {
 //BucketNotificationsSpec controls bucket notification configuration
 type BucketNotificationsSpec struct {
 	// Enabled - whether bucket notifications is enabled
-	Enabled bool `json:"enabled,omitempty"`
+	Enabled bool `json:"enabled"`
 
 	//PVC (optional) specifies the name of the Persistent Volume Claim (PVC) to be used
 	//for holding pending notifications files.

diff --git a/pkg/bundle/deploy.go b/pkg/bundle/deploy.go
@@ -1415,7 +1415,7 @@ spec:
       status: {}
 `
 
-const Sha256_deploy_crds_noobaa_io_noobaas_yaml = "fc8943fe4594fa65ff3bd56aea9271211d15f6d9ae692ee8223e51b3771c42e5"
+const Sha256_deploy_crds_noobaa_io_noobaas_yaml = "e862d263d097ed43f774784eaaf9a616967746b67608fadbe4ca71d93b220ab6"
 
 const File_deploy_crds_noobaa_io_noobaas_yaml = `---
 apiVersion: apiextensions.k8s.io/v1
@@ -2480,6 +2480,8 @@ spec:
                       for holding pending notifications files.
                       For ODF - If not provided, the default CepthFS storage class will be used to create the PVC.
                     type: string
+                required:
+                - enabled
                 type: object
               cleanupPolicy:
                 description: CleanupPolicy (optional) Indicates user's policy for